-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[Spring]Added support for composed annotations (@GetMapping,@PostMapping,@PutMapping,@DeleteMapping). #21118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Spring]Added support for composed annotations (@GetMapping,@PostMapping,@PutMapping,@DeleteMapping). #21118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dRbAndrade, thanks for the PR!
Could you please take care of the review comments below and also add your new lambda to this section in the docs:
openapi-generator/docs/templating.md
Line 817 in 4cffd32
## Mustache Lambdas |
modules/openapi-generator/src/main/resources/JavaSpring/api.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java
Show resolved
Hide resolved
...ava/org/openapitools/codegen/templating/mustache/ComposedRequestMappingAnnotationLambda.java
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/JavaSpring/api.mustache
Outdated
Show resolved
Hide resolved
Hello, @martin-mfg ! I have updated with the requested changes, but I would advise against addting my lambda to the templating.md file because I can see all other lambdas are general purpose and can pretty much be used everywhere. Mine is very specific and has really no other use othe than this and should not be used by anyone else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated with the requested changes, but I would advise against addting my lambda to the templating.md file because I can see all other lambdas are general purpose and can pretty much be used everywhere. Mine is very specific and has really no other use othe than this and should not be used by anyone else.
Good point, I agree. Since the new lambda is not general purpose, I guess it should not be created in DefaultCodegen but instead in SpringCodegen. Like this.
Also, please run ./bin/utils/export_docs_generators.sh
to update the documentation.
I have noticed that when using the Spring generator, the API interface file would contain @RequestMapping(method = RequestMethod.) annotation. This would isn't exactly an issue but would be a code smell under sonar coding rule java:s4488 https://sonarsource.github.io/rspec/#/rspec/S4488. I tried to search for an existing way to change it but could not find it. So I went ahead and added the support myself.
This is a change for Java Spring generator so I'm tagging the committee:
@cachescrubber @welshm @MelleD @atextor @manedev79 @javisst @borsch @banlevente @Zomzog @martin-mfg
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)